Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish subtyping relationships for type extractors #1446

Merged
merged 2 commits into from Mar 15, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Mar 12, 2021

📔 Description

This works already, but the checklist demands a bit more time investment.

📝 Checklist

🎯 Review Instructions

By commit.

Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I looked a the code, unit test, and integration test.

I didn't give it a spin yet, though. It'd be great if someone else from @tenzir/backend could play with it for a few mins and try to break it.

@tobim tobim marked this pull request as ready for review March 12, 2021 21:44
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and tests are fine by me. This seems to work nicely in practice—I've toyed around with this with a few simple tests and the output matched my expectations.

@tobim tobim merged commit 6a9eac1 into master Mar 15, 2021
@tobim tobim mentioned this pull request Mar 15, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants