Report metrics while idle #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, VAST skipped metrics reports for the archive, importer, source, and sink components when they handled 0 events since the last metric report. This made it impossible to distinguish on metrics dashboards whether a component was offline or idle. Instead, VAST now properly reports 0 events while idle.
dominiklohmann
force-pushed
the
story/ch23346/metrics-while-idle
branch
from
9da8bdb
to
d389d8b
Compare
lava
approved these changes
Mar 17, 2021
| else | ||
| self->state->record(key + ".rate", | ||
| std::numeric_limits<decltype(rate)>::max(), ts); | ||
| if (value.events == 0) { |
There was a problem hiding this comment.
As discussed on slack, this special case shouldnt be necessary but empirically we observed that we sometimes receive records with 0 events and 0 duration.
(just leaving this comment in case anyone wonders and looks at the PR in the future)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摂 Description
Previously, VAST skipped metrics reports for the archive, importer, source, and sink components when they handled 0 events since the last metric report. This made it impossible to distinguish on metrics dashboards whether a component was offline or idle. Instead, VAST now properly reports 0 events while idle.
馃摑 Checklist
馃幆 Review Instructions
File-by-file.