Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VAST_REGISTER_PLUGIN_TYPE_ID_BLOCK_2 #1452

Merged
merged 1 commit into from Mar 17, 2021
Merged

Fix VAST_REGISTER_PLUGIN_TYPE_ID_BLOCK_2 #1452

merged 1 commit into from Mar 17, 2021

Conversation

dominiklohmann
Copy link
Member

馃摂 Description

We only test the single argument version in CI, so this slipped through until I tried to actually use it.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

n/t

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Mar 16, 2021
@dominiklohmann dominiklohmann requested a review from a team March 16, 2021 14:44
@dominiklohmann
Fix VAST_REGISTER_PLUGIN_TYPE_ID_BLOCK_2
62abf9e 
We only test the single argument version in CI, so this slipped through
until I tried to actually use it.
tobim
tobim approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That obviously couldn't work.

@tobim tobim merged commit 0c43ea3 into master Mar 17, 2021
@tobim tobim deleted the topic/plugin-type-id-bug branch March 17, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees

@tobim tobim

Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
2 participants
@dominiklohmann @tobim