Ignore static plugins when specified in config #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch24016/ignore-specified-static-plugins
branch
2 times, most recently
from
cc3810f
to
5d2821b
Compare
Base automatically changed from
story/ch24015/align-plugin-and-library-names
to
master
April 6, 2021 19:25
tobim
requested changes
Apr 7, 2021
dominiklohmann
force-pushed
the
story/ch24016/ignore-specified-static-plugins
branch
2 times, most recently
from
459b74d
to
13e8a9b
Compare
This commit changes VAST to ignore plugins specified in the `vast.yaml` when static versions of them are already loaded. Aside from being the correct thing to do, this fixes an issue with the integration test suite where plugin integration tests specify their name in a `vast.yaml` file used for their tests.
dominiklohmann
force-pushed
the
story/ch24016/ignore-specified-static-plugins
branch
from
13e8a9b
to
5bc1abe
Compare
tobim
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摂 Description
This commit changes VAST to ignore plugins specified in the
vast.yamlwhen static versions of them are already loaded.Aside from being the correct thing to do, this fixes an issue with the integration test suite where plugin integration tests specify their name in a
vast.yamlfile used for their tests.馃摑 Checklist
馃幆 Review Instructions
File-by-file. Note that this is based on #1527 and cannot work without that change.