Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the timezone shift to UTC for ISO8601 dates #1537

Merged
merged 1 commit into from Apr 8, 2021
Merged

Fix the timezone shift to UTC for ISO8601 dates #1537

merged 1 commit into from Apr 8, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Apr 8, 2021

馃摂 Description

One has to subtract positive offsets and add negative ones to arrive at the correct UTC timestamp value. We did that the wrong way up to now.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

Manually verify that the test expectations are now correct.

@tobim
Fix the timezone shift to UTC for ISO8601 dates
e199fce 
One has to subtract positive offsets and add negative ones to arrive
at the correct UTC timestamp value. We did that the wrong way up to
now.
@tobim tobim added the bug Incorrect behavior label Apr 8, 2021
@tobim tobim requested a review from a team April 8, 2021 15:16
lava
lava approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy to think that we had such a bug for so long without noticing. But of course if the tests are testing the wrong thing, that doesn't help :D

@tobim tobim enabled auto-merge April 8, 2021 15:29
@tobim tobim merged commit 3a2d907 into master Apr 8, 2021
@tobim tobim deleted the story/ch23526/timzone-wrong-shift branch April 8, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
2 participants
@tobim @lava