Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a possible deadlock in component plugins #1547

Merged
merged 1 commit into from Apr 13, 2021
Merged

Fix a possible deadlock in component plugins #1547

merged 1 commit into from Apr 13, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Apr 13, 2021 •
edited

馃摂 Description

Component plugins were spawned before all other components were ready necessarily. This introduced a possible deadlock when trying to get other components from the NODE as part of the initialization of a component plugins actor.

The solution is to simply spawn components from component plugins last.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

File- by-file.

Sorry for introducing this one, I overlooked it when developing #1544.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Apr 13, 2021
@dominiklohmann dominiklohmann requested a review from a team April 13, 2021 08:15
@dominiklohmann
Fix a possible deadlock in component plugins
3ca580c 
Component plugins were spawned before all other components were ready
necessarily. This introduced a possible deadlock when trying to get
other components from the NODE as part of the initialization of a
component plugins actor.

The solution is to simply spawn components from component plugins last.
@dominiklohmann dominiklohmann force-pushed the topic/component-plugin-deadlock branch from 8686e62 to 3ca580c Compare April 13, 2021 08:15
lava
lava approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable; I didn't test but it sounds like dependabot already did that in this case. (also, the PR is just moving code around, so the chance of breakage should be low)

@dominiklohmann dominiklohmann merged commit 1961ee9 into master Apr 13, 2021
@dominiklohmann dominiklohmann deleted the topic/component-plugin-deadlock branch April 13, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
2 participants
@dominiklohmann @lava