Multiple node shutdown fixes #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
requested changes
Apr 21, 2021
There was a problem hiding this comment.
Mostly looking good. Ran this locally and it reduced the shutdown time with plugins a lot. Your reasoning why this fixes the rare assertion failure in CI seems sound to me.
This PR needs two changelog entries:
bug-fixesfor the rare assertion failure fixfeaturesfor the parallel shutdown of auxiliary actors
- We've been terminating non-essential components after the main ones, but now we do it before. - We don't try to terminate remote actors any more. - The shutdown sequence used to treat labels as types, which means the actor of the label wouldn't be terminated at all and keeping the process alive.
tobim
force-pushed
the
story/ch24577/shutdown-fixes
branch
from
6eae71a
to
597385f
Compare
tobim
force-pushed
the
story/ch24577/shutdown-fixes
branch
from
59cbb94
to
df7e4c3
Compare
-> done.
I doubt this will really be noticeable under normal circumstances. That change was mostly done to speed things up in case on of the components is not responsive. |
| The shutdown logic contained a bug that would make the node fail to terminate | ||
| in case a plugin actor is registered at said node. | ||
|
|
||
| A race condition in the shutdown logic that caused an assertion was fixed. |
There was a problem hiding this comment.
Every paragraph is a changelog entry of its own, I doubt this is what you wanted to achieve here.
There was a problem hiding this comment.
These are 2 separate Bugs that are both fixed in this PR.
dominiklohmann
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摂 Description
ones, but now we do it before.
the actor of the label wouldn't be terminated at all and keeping
the process alive.
馃摑 Checklist
馃幆 Review Instructions
By commit.