Skip to content

Deduplicate plugin entrypoint in sources #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2021
Merged

Deduplicate plugin entrypoint in sources #1573

merged 2 commits into from
Apr 23, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Apr 23, 2021 •
edited
Loading

📔 Description

Two smaller bug fixes:

  • nix/static-binary.sh now works again when invoked from somewhere other than the repository root.
  • The VASTRegisterPlugin CMake function now correctly removes the ENTRYPOINT from the given SOURCES.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commit-by-commit.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Apr 23, 2021
@dominiklohmann dominiklohmann requested a review from tobim April 23, 2021 10:06
@dominiklohmann dominiklohmann force-pushed the topic/deduplicate-plugin-entrypoint branch from 8643171 to ae4c742 Compare April 23, 2021 10:16
@dominiklohmann dominiklohmann merged commit 215dde3 into master Apr 23, 2021
@dominiklohmann dominiklohmann deleted the topic/deduplicate-plugin-entrypoint branch April 23, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim