Error when initializing a plugin fails #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/plugin-error-on-failed-initialize
branch
from
2488628 to
11cbfbc
Compare
There's no point in `plugin::initialize()` returning an error if it's never checked. So let's actually check and refuse to start if any plugin fails to initialize.
dominiklohmann
force-pushed
the
topic/plugin-error-on-failed-initialize
branch
from
11cbfbc to
5842215
Compare
mavam
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
There's no point in
plugin::initialize()returning an error if it's never checked. So let's actually check and refuse to start if any plugin fails to initialize.📝 Checklist
🎯 Review Instructions
The change is really simple, so looking at the code should suffice.