Allow for running unit tests in parallel #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch25558/parallel-unit-tests
branch
from
b7b4671
to
8ad2352
Compare
lava
approved these changes
May 17, 2021
Before this change, the filesystem unit test fixture used a fixed `vast-unit-test` root directory. Now, we use `vast-unit-test/<suite>` instead to avoid races when running tests in parallel, e.g., via `ctest -j12 -C Debug`.
dominiklohmann
force-pushed
the
story/ch25558/parallel-unit-tests
branch
from
8ad2352
to
8a752b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摂 Description
Before this change, the filesystem unit test fixture used a fixed
vast-unit-testroot directory. Now, we usevast-unit-test/<suite>instead to avoid races when running tests in parallel, e.g., viactest -j12 -C Debug.馃摑 Checklist
馃幆 Review Instructions
Test locally via