Sort loaded plugins by name #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the version comparison is agnostic to the order of the plugins.
dominiklohmann
force-pushed
the
story/ch25770/plugin-load-order
branch
from
fc0d4af
to
78438f7
Compare
lava
approved these changes
May 25, 2021
There was a problem hiding this comment.
I don't have a setup to test, but looking it the code it seems pretty safe to say that it should work.
Relying on the order being setup during startup is a very implicit way of doing this, but long-term the issue should resolve itself anyways as soon as record comparisons become order-independent.
A better fix would probably be to use a stable set for this with a custom equal_to function object, but that is far more than we need to fix this before the release. I'll write a story for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摂 Description
This ensures the version comparison is agnostic to the order of the plugins.
馃摑 Checklist
馃幆 Review Instructions
Connect a local VAST to a VAST running the same plugins specified in a different order and notice VAST no longer warns unnecessarily.