Publish a tenzir/vast-dev Docker image #1749
Merged
+143
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch25657/vast-dev-docker-image
branch
2 times, most recently
from
6f68995
to
575dc4e
Compare
tobim
requested changes
Jun 29, 2021
dominiklohmann
force-pushed
the
story/ch25657/vast-dev-docker-image
branch
2 times, most recently
from
df46bd6
to
9ca0f4a
Compare
mavam
reviewed
Jun 30, 2021
This is a complete refactoring of our Docker images, and trims the size of the resulting production image down to just 350MB. We now offer a `tenzir/vast-dev` variant besides the regular `tenzir/vast` Docker images that is designed to be used in development contexts, e.g., when building additional plugins. The individual stages are labelled `development` and `production` respectively. To build the development image locally, use `docker build . --target development`.
dominiklohmann
force-pushed
the
story/ch25657/vast-dev-docker-image
branch
from
9ca0f4a
to
b78b6b9
Compare
tobim
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This is a complete refactoring of our Docker images, and trims the size of the resulting production image down to just 350MB. We now offer a
tenzir/vast-devvariant besides the regulartenzir/vastDocker images that is designed to be used in development contexts, e.g., when building additional plugins. The individual stages are labelleddevelopmentandproductionrespectively. To build the development image locally, usedocker build . --target development.📝 Checklist
🎯 Review Instructions
n/t