Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont abort JSON import when encountering non-objects #1759

Merged
merged 3 commits into from Jul 6, 2021
Merged

Dont abort JSON import when encountering non-objects #1759

merged 3 commits into from Jul 6, 2021

Conversation

lava
Copy link
Member

@lava lava commented Jul 6, 2021 •
edited

馃摂 Description

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

tobim
tobim approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing punctuation. Other than that it is in line with the other existing skip branches.

@lava @tobim
Add missing punctuation.
4ecb679 
Co-authored-by: tobim <tobim@fastmail.fm>
@lava lava merged commit 923f7e1 into master Jul 6, 2021
@lava lava deleted the story/ch26846/json-import-error branch July 6, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lava @tobim