Normalize GNUInstallDirs for external plugins #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins built against an installed VAST expect relative GNUInstallDirs, which some package managers (looking at you, Nix) stupidly set to absolute paths. This patch externalizes our normalization we do for VAST normally and applies it to all dynamic plugins.
dominiklohmann
force-pushed
the
topic/normalize-install-dirs-plugins
branch
from
df9d9fc
to
579b1d6
Compare
tobim
reviewed
Jul 19, 2021
cmake/VASTRegisterPlugin.cmake
Outdated
Comment on lines
25
to
26
| # stupid thing where they put absolute paths into variables that are | ||
| # supposed to be interpreted as relative to the install preifx. |
There was a problem hiding this comment.
This comment is too strong. The documentation explicitly states:
... However, an absolute path is also allowed.
In some cases absolute paths make sense, and we should probably only do this in relocatable mode for plugins too.
There was a problem hiding this comment.
I toned the comment down, and made the requested change.
Additionally, this stops the copying of bundled schemas to the build directory for non-reloctable installations, which may not be executed from the build directory context anyways, and makes them function for `CMAKE_INSTALL_DATADIR` other than `share`.
tobim
approved these changes
Jul 20, 2021
|
Tested with the static build locally. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Plugins built against an installed VAST expect relative GNUInstallDirs, which some package managers (looking at you, Nix) stupidly set to absolute paths. This patch externalizes our normalization we do for VAST normally and applies it to all dynamic plugins.
📝 Checklist
🎯 Review Instructions
Test it locally by setting
-D CMAKE_INSTALL_PREFIX=${PWD}/build.install -D CMAKE_INSTALL_LIBDIR=${PWD}/build.install/libor similar.