Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing concepts for Suricata events #1798

Merged
merged 3 commits into from Jul 30, 2021
Merged

Add missing concepts for Suricata events #1798

merged 3 commits into from Jul 30, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Jul 23, 2021 •
edited

馃摂 Description

馃摑 Checklist

  • All user-facing changes have changelog entries.

@tobim tobim added the maintenance Tasks for keeping up the infrastructure label Jul 23, 2021
@tobim tobim requested a review from a team July 23, 2021 09:48
@dominiklohmann
Copy link
Member

Is this exempt from the feature freeze? Should we merge this and add an rc2?

@tobim
Copy link
Member Author

tobim commented Jul 23, 2021

In my opinion this is very low risk, but I would not want to force an rc2 just for this.

@dominiklohmann
Copy link
Member

dominiklohmann commented Jul 23, 2021 •
edited

Then let's only merge this if we need another fixup.

@mavam mavam changed the title Add missing concepts for suricata events Add missing concepts for Suricata events Jul 26, 2021
@mavam mavam added blocked Blocked by an (external) issue and removed blocked Blocked by an (external) issue labels Jul 26, 2021
lava
lava approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not verify in detail that the updated concept fields are correct, but the gist of the PR looks good to me.

@tobim tobim merged commit 0fd652f into master Jul 30, 2021
@tobim tobim deleted the story/ch23319/suricata-concepts branch July 30, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
4 participants
@tobim @dominiklohmann @lava @mavam