Fix possible desync in pending queries map #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch28319/pending-query-map-mismatch
branch
from
0651167
to
c24b2f3
Compare
This changes the INDEX to monitor EXPORTER actors in order to be able to remove pending queries when an EXPORTER goes down unexpectedly without cancelling its running queries. This fixes a msimatch in the pending queries map in the output of `vast status --detailed`, and also stops the index from doing further unnecessary work if an export was unexpectedly killed.
dominiklohmann
force-pushed
the
story/ch28319/pending-query-map-mismatch
branch
from
9d2bd11
to
a903616
Compare
lava
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摂 Description
This changes the INDEX to monitor EXPORTER actors in order to be able to remove pending queries when an EXPORTER goes down unexpectedly without cancelling its running queries. This fixes a mismatch in the pending queries map in the output of
vast status --detailed, and also stops the index from doing further unnecessary work if an export was unexpectedly killed.馃摑 Checklist
馃幆 Review Instructions
Commit-by-commit. Play around with it locally by killing processes off.