Fix response promises for disk monitor deletion #1892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/local-segment-stores-erase
branch
from
aa99c3f to
a1c2b9d
Compare
dominiklohmann
force-pushed
the
topic/local-segment-stores-erase
branch
from
26858fc to
2660f78
Compare
tobim
requested changes
Sep 28, 2021
|
The changes you made look fine to me. I can't approve my own PR, but consider your mixups approved @tobim. |
With the new pending_partitions counter I took the liberty to avoid state duplication and use that to check whether we can start another round.
tobim
force-pushed
the
topic/local-segment-stores-erase
branch
from
ac45b99 to
d8fc3d3
Compare
tobim
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
In the testing of the release candidate we noticed the disk monitor not correctly handling deletion in some cases, leading to full disks. These changes are a first attempt at solving the issue.
📝 Checklist
🎯 Review Instructions
atom::pinghandler of the disk monitor down to the local segment stores.