Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to the index #1942

Merged
merged 8 commits into from Nov 3, 2021
Merged

Conversation

tobim
Copy link
Member

@tobim tobim commented Nov 2, 2021

📝 Checklist

  • A metrics heartbeat is added back to the index.
  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commits 2 and 3 are only moving code around and don't contain any logical changes.

@tobim tobim force-pushed the story/sc-28704/backlog-introspection branch from b2aefa9 to 16403ce Compare November 2, 2021 16:51
@tobim tobim force-pushed the story/sc-28704/backlog-introspection branch from 16403ce to fd87c05 Compare November 3, 2021 08:03
@tobim tobim force-pushed the story/sc-28704/backlog-introspection branch from fd87c05 to 947f5f4 Compare November 3, 2021 08:27
@tobim tobim marked this pull request as ready for review November 3, 2021 08:36
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metrics work as expected. Here's a diff that makes the unit tests compile:

diff --git a/libvast/test/system/eraser.cpp b/libvast/test/system/eraser.cpp
index b60dfb991..f0b478c1e 100644
--- a/libvast/test/system/eraser.cpp
+++ b/libvast/test/system/eraser.cpp
@@ -70,6 +70,9 @@ mock_index(system::index_actor::stateful_pointer<mock_index_state> self) {
     [=](system::accountant_actor&) {
       FAIL("no mock implementation available");
     },
+    [=](atom::telemetry) {
+      FAIL("no mock implementation available");
+    },
     [=](atom::status, system::status_verbosity) -> record {
       FAIL("no mock implementation available");
     },
diff --git a/libvast/test/system/query_processor.cpp b/libvast/test/system/query_processor.cpp
index 5712a0017..d72406d51 100644
--- a/libvast/test/system/query_processor.cpp
+++ b/libvast/test/system/query_processor.cpp
@@ -49,6 +49,9 @@ mock_index(system::index_actor::stateful_pointer<mock_index_state> self) {
     [=](system::accountant_actor) {
       FAIL("no mock implementation available");
     },
+    [=](atom::telemetry) {
+      FAIL("no mock implementation available");
+    },
     [=](atom::status, system::status_verbosity) -> record {
       FAIL("no mock implementation available");
     },

@tobim tobim merged commit 0b38953 into master Nov 3, 2021
@tobim tobim deleted the story/sc-28704/backlog-introspection branch November 3, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants