Make JSON field selectors configurable #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `--selector=<field>[:<prefix>]` option to the JSON import. The *field* contains the *event name*, which when prefixed with the optional *prefix* is used for selecting the event type. This previously existed as a hard-coded option for the Zeek Stremaing JSON and Suricata Eve JSON readers, which still exist unchanged. The following commands are now equivalent: ```sh # Import Suricata Eve JSON vast import suricata vast import json --selector=event_type:suricata # Import Zeek Streaming JSON vast import zeek-json vast import json --selector=_path:zeek ```
dominiklohmann
force-pushed
the
story/sc-29697/import-json-selector
branch
from
c09eee5
to
e081d9c
Compare
dominiklohmann
commented
Nov 22, 2021
|
How could I interpret this with the upcoming schema module changes? Would |
Yes, exactly. |
dominiklohmann
force-pushed
the
story/ch20439/type-flatbuffers
branch
from
a41ee3f
to
af9a22a
Compare
Before this change, running `vast spawn import json --selector=:` allowed users to crash the connected to VAST server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
--selector=<field>[:<prefix>]option to the JSON import. The field contains the event name, which when prefixed with the optional prefix is used for selecting the event type.This previously existed as a hard-coded option for the Zeek Stremaing JSON and Suricata Eve JSON readers, which still exist unchanged.
The following commands are now equivalent:
馃摑 Checklist
馃幆 Review Instructions
File-by-file. I left some notes as review comments that are helpful to look at.
Note that this is based on #1888 to avoid merge conflicts.