Add metadata elements to the metrics events #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this is a user-facing change: adapting the metrics layout requires a changelog entry and a documentation update.
Can you also expand on why you are making this change? That's not immediately obvious from the PR description, and I think it really should be.
tobim
force-pushed
the
story/ch26781/query-id
branch
from
f50077c
to
d912328
Compare
tobim
force-pushed
the
story/sc-29855/feature/metrics-metatdata
branch
2 times, most recently
from
6d6aaa9
to
24bcb22
Compare
The periodic throughput status message to STDOUT has been broken since we switched to spdlog for logging. We never heard a complaint about that so it's save to remove that logic now. The status command can be used as an alternative way to make sure the system is operating correctly.
This change makes it possible to add pairs of strings as metatdata to a metrics event.
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
tobim
force-pushed
the
story/sc-29855/feature/metrics-metatdata
branch
from
24bcb22
to
1e780de
Compare
6yozo
approved these changes
Dec 8, 2021
tobim
force-pushed
the
story/sc-29855/feature/metrics-metatdata
branch
from
1e780de
to
03f68df
Compare
|
I had to push once more to fix the formatting in the changelog message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to add pairs of strings as metadata to a metrics event.
This also removes code for the defunct server side STDOUT heartbeat and 2 commits adding accountant actor handles to the meta index and partition in preparation of additional metrics.
This depends on #1986.
📝 Checklist
🎯 Review Instructions
By commit.