Fix JSON default selector for nested records #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elector-for-nested-records
tobim
approved these changes
Dec 7, 2021
dominiklohmann
deleted the
topic/fix-default-selector-for-nested-records
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the JSON default selector which does field name based matching to correctly function for nested record types (and thus nested JSON objects).
The fix is currently based off of the last release to create a one-off binary and (1) needs additional tests to be written and (2) needs to be rebased onto actual master. We don't want to create a general hot fix release for this.📝 Checklist
🎯 Review Instructions
Don't yet.It's a two-line fix that should be fairly simple to follow.