Emit fine grained metrics for every part of the query pipeline #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
commented
Dec 7, 2021
tobim
commented
Dec 7, 2021
|
I'm approving of the changes to the plugin interface. We should consider making it a component plugin in the future, though, but this PR is neither the time nor the place to do it. |
tobim
force-pushed
the
story/sc-29855/feature/metrics-metatdata
branch
2 times, most recently
from
1e780de
to
03f68df
Compare
Base automatically changed from
story/sc-29855/feature/metrics-metatdata
to
master
December 8, 2021 15:48
The exporter used to keep the expression only, but we are actually interested in the ID and parameters too.
The underlying issue has been resolved with commit 0555580.
tobim
force-pushed
the
story/sc-29856/feature/query-pipeline-metrics
branch
from
4a8eb62
to
1aa2620
Compare
6yozo
reviewed
Dec 9, 2021
6yozo
reviewed
Dec 9, 2021
On some systems `int64_t` is defined as `singed long int`, but the representation for the duration of `std::chrono::steady_clock` can be different. This caused a typed mpi mismatch that is hereby fixed.
tobim
force-pushed
the
story/sc-29856/feature/query-pipeline-metrics
branch
from
ba9f97b
to
87d3acd
Compare
6yozo
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds metrics events that are emitted for each query from the meta index, partition and store components. All new metrics and the preexisting exporter metrics events use the query ID as metadata value to allow cross-referencing.
馃摑 Checklist
馃幆 Review Instructions
Each commit can be reviewed individually in order.
The last commit modifies the interface of the store plugin, which is unfortunate and I would like to discuss alternative approaches.