Implement a generic aggregation transform step #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/generic-aggregation-plugin
branch
from
b47fbc8 to
19f4bdc
Compare
|
Awesome to see the Arrow Compute API being leveraged! |
dominiklohmann
force-pushed
the
topic/generic-aggregation-plugin
branch
2 times, most recently
from
0dbf8a2 to
1ae64b0
Compare
dominiklohmann
commented
Feb 10, 2022
dominiklohmann
commented
Feb 10, 2022
dominiklohmann
commented
Feb 10, 2022
mavam
reviewed
Feb 10, 2022
dominiklohmann
commented
Feb 13, 2022
dispanser
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Fine with me! Made a minor comment, also assuming you're going to repair the build 🗡️
Digging through the arrow APIs, I found https://arrow.apache.org/docs/dev/cpp/compute.html#grouped-aggregations-group-by which may one day become an off-the-shelf way to do this without explicitly handling the grouping ourselves.
Great to see that generic and powerful aggregation plugin 👍
@dispanser the main issue is that this only supports grouping on a single column, which is insufficient for our use cases. |
mavam
reviewed
Feb 14, 2022
mavam
reviewed
Feb 14, 2022
This implements a generic aggregation transform step plugin. E.g., to configure
it for flow aggregation on export, the following may be used:
```yaml
vast:
transforms:
suricata-flow-aggregate:
- aggregate:
time-window: 10 seconds
group-by:
- timestamp
- src_ip
- dest_ip
- dest_port
- proto
- event_type
sum:
- pcap_cnt
- flow.pkts_toserver
- flow.pkts_toclient
- flow.bytes_toserver
- flow.bytes_toclient
min:
- flow.start
max:
- flow.end
any:
- flow.alerted
# all:
layout-name: suricata.aggregated_flow
- replace:
field: event_type
value: aggregated_flow
transform-triggers:
export:
- transform: suricata-flow-aggregate
location: client
events:
- suricata.flow
- suricata.aggregated_flow
```
This is a rewrite of the aggregate transform step and its underlying algorithm to have two passes, each of which can be disabled: An eager pass when adding record batches, and a lazy pass when retrieving the results. Additionally, it refactors the per-layout aggregation into a separate data structure that is easier to maintain, and adds explanatory comments throughout the file.
This fixes some minor issues in the aggregate plugin noticed during a review session.
dominiklohmann
force-pushed
the
topic/generic-aggregation-plugin
branch
from
11893a9 to
1a8ab52
Compare
dominiklohmann
commented
Feb 14, 2022
dominiklohmann
force-pushed
the
topic/generic-aggregation-plugin
branch
from
0fb7540 to
0c98662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a generic aggregation transform step plugin. See the attached README file for more information.
📝 Checklist
🎯 Review Instructions
File-by-file. Go over the algorithm in a call with me. Test locally alongside compaction.