Improve name lookup in meta index to reduce FPs #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/sc-31649/slow-queries
branch
from
31fdbdd
to
9b421fa
Compare
tobim
reviewed
Feb 16, 2022
The candidate check of the meta index must use the proper suffix matching algorithm of the type system rather than plain suffix matching on a flat qualified record field's name in order to avoid false positive candidate partitions. E.g., the field extractor "ts" resolved to partitions that contained layouts with a field names "orig_pkts" rather than just those that only contained a field exactly named "ts". This change fixes that behavior.
dominiklohmann
force-pushed
the
story/sc-31649/slow-queries
branch
from
9b421fa
to
6023b61
Compare
tobim
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The candidate check of the meta index must use the proper suffix matching algorithm of the type system rather than plain suffix matching on a flat qualified record field's name in order to avoid false positive candidate partitions. E.g., the field extractor "ts" resolved to partitions that contained layouts with a field names "orig_pkts" rather than just those that only contained a field exactly named "ts". This change fixes that behavior.
馃摑 Checklist
馃幆 Review Instructions
@tobim please verify that this fixes the issue you've described. The check itself is rather simple.
This does not need a changelog entry since it should only be a speed improvement for some queries, but does not change any behavior in a user-facing way.