Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust index statistics for partition transforms #2097

Merged
merged 5 commits into from Feb 22, 2022
Merged

Adjust index statistics for partition transforms #2097

merged 5 commits into from Feb 22, 2022

Conversation

lava
Copy link
Member

@lava lava commented Feb 18, 2022 •
edited

  • Adjust index statistics for partition transforms
  • Return partition_info from apply handler

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

Review commit-by-commit.

@lava
Use robin_map as heterogenous string map
5c56e58
@lava
Adjust index statistics for partition transforms
10fc4ea
@lava
Return partition_info from apply handler
1e472ac 
Minimize the sending around of partition_synopsis,
which are non-serializable, expensive to copy, hold
much more info than required by existing users, and
technically are an implementation detail.

Instead, return the newly created `partition_info`
struct instead.
@lava lava force-pushed the topic/partition-transformer-type-registry branch from 7d854ce to 1e472ac Compare February 21, 2022 10:20
@dominiklohmann dominiklohmann added the bug Incorrect behavior label Feb 21, 2022
@tobim tobim self-assigned this Feb 21, 2022
tobim
tobim requested changes Feb 21, 2022
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the overall solution is fine but I hope we can find a better way to slice partition_synopsis and partition_info.

libvast/vast/fwd.hpp Outdated Show resolved Hide resolved
libvast/vast/partition_synopsis.hpp Show resolved Hide resolved
libvast/src/system/index.cpp Show resolved Hide resolved
@tobim tobim removed their assignment Feb 21, 2022
dominiklohmann
dominiklohmann approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, left some comments inline.

libvast/vast/index_statistics.hpp Show resolved Hide resolved
@lava lava merged commit 914fe00 into master Feb 22, 2022
@lava lava deleted the topic/partition-transformer-type-registry branch February 22, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
3 participants
@lava @tobim @dominiklohmann