New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy VAST to AWS Lambda #2108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you so much.
I've tested it following the readme, and was able to deploy vast, import data, query data, ... so everything works as expected.
Two points:
- I'm not sure the approach using environment variables /
default.env
is optimal. In my previous usages of terraform, I always relied ontfvars
files to inject behavior (and some defaults for the variables). I can see how the approach taken here makes working with the Makefile easier, but it stops us from usingterraform
directly. - Now that you added the ability to directly execute commands on the ecs task using
make execute-command
, the existence of lambda functions is not strictly necessary any more. It's a nice showcase for how to integrate, and lambda is practically free, so it's not really a problem.
My suggestion would be to move forward as is, and see how this actually gets used and adapt it from these learnings.
I don't love this
Yeah, I think I over-engineered this a bit 馃槄. But I believe it can be very useful if you want to add extra tooling around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the CI changes as well.
@rdettai we require all commits to have a valid signature, which is why your PR cannot be merged currently. Do you have the setup for signing commits locally so you can rebase, or should I rebase this PR leaving you as the author of the commits and me as the (signing) committer? |
I'll setup the signature and rebase |
@dominiklohmann done! you can re-activate auto-merge ;-) |
This changes adds the possibility to deploy VAST on AWS Lambda and Fargate. This is a more interesting feature set as it will enable connecting to the VAST server on Fargate through client VAST instances on Lambda
馃摑 Checklist
馃幆 Review Instructions
This PR can be broken down into: