Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the get subcommand #2121

Merged
merged 1 commit into from Mar 6, 2022
Merged

Remove the get subcommand #2121

merged 1 commit into from Mar 6, 2022

Conversation

tobim
Copy link
Member

@tobim tobim commented Feb 27, 2022

The vast get command was never useful except for debugging and it can't be made ergonomic with partition local ids, so it's better to remove it.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

Search for leftovers?

@tobim
Remove the get subcommand
6992955 
The `vast get` command was never useful except for debugging and it
can't be made ergonomic with partition local ids, so it's better to
remove it.
@tobim tobim added the maintenance Tasks for keeping up the infrastructure label Feb 27, 2022
@tobim tobim requested a review from a team February 27, 2022 20:07
@dominiklohmann dominiklohmann added blocked Blocked by an (external) issue and removed blocked Blocked by an (external) issue labels Feb 28, 2022
dominiklohmann
dominiklohmann approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real use case we had for this was the initial version of the Live Matching feature back in 2020. I don't see why we need to drag this feature around any longer. Let's get a step closer to having partition-local ID spaces!

@tobim tobim merged commit cf41e60 into master Mar 6, 2022
@tobim tobim deleted the topic/remove-vast-get branch March 6, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
2 participants
@tobim @dominiklohmann