Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename meta-index to catalog #2128

Merged
merged 2 commits into from Mar 3, 2022
Merged

Rename meta-index to catalog #2128

merged 2 commits into from Mar 3, 2022

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Mar 1, 2022

We've long been searching for a new name for the meta index, as there exist already multiple things named index inside VAST. An internal vote resulted in the name catalog winning.

This change also affects a keys in the output of vast status and in certain metrics, and is thus a breaking change.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

Verify that git-grep only shows old changelog entries for relevant queries.

@dominiklohmann dominiklohmann added the refactoring Restructuring of existing code label Mar 1, 2022
@dominiklohmann dominiklohmann requested a review from a team March 1, 2022 19:24
@dominiklohmann dominiklohmann force-pushed the story/sc-31749/catalog branch 2 times, most recently from 0b93b58 to 30a8bd6 Compare March 1, 2022 19:30
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These first substitutional changes are fine.

It feels that renaming the index should be done in here as well.

@dominiklohmann
Copy link
Member Author

It feels that renaming the index should be done in here as well.

A quick vote in Slack said that this should be a separate PR.

We've long been searching for a new name for the meta index, as there exist
already multiple things named index inside VAST. An internal vote resulted in
the name `catalog` winning.

This change also affects a keys in the output of `vast status` and in certain
metrics, and is thus a breaking change.
@dominiklohmann dominiklohmann merged commit fbffb70 into master Mar 3, 2022
@dominiklohmann dominiklohmann deleted the story/sc-31749/catalog branch March 3, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Restructuring of existing code
Projects
None yet
2 participants