Load stores lazily #2146
Merged
Load stores lazily #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a changelog entry. After measuring locally, this turned out to have a visible effect for a small test database with 100 partitions. Quantifying the speed up does not make sense here, as it is highly dependent on the disk speeds and the operating system's scheduling of file reads / mmaps. |
lava
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes local segment stores of passive partitions to be loaded lazily, i.e., initialized only after the actor received its first message.
📝 Checklist
🎯 Review Instructions
I was unable to reproduce the behavior from the removed comment locally. Please make sure this also holds true for other platforms.
It'd be great to measure this—if the impact is big, then we probably want to add a changelog entry.