Support environment variables as alternate config mechanism #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
force-pushed
the
topic/environment-variables
branch
from
8aad83a
to
d74d900
Compare
|
@tenzir/vast how would you test this feature? |
dominiklohmann
approved these changes
Mar 25, 2022
mavam
commented
Mar 28, 2022
lava
reviewed
Mar 29, 2022
Given that --verbosity was basically a non-existent config option, we should have been mapping the shorthands to --console-verbosity in the first place.
This is another stab at breaking up the giant monolith function and making it more side-effect free. This one might appear as zero-sum refactoring because we're adding a singleton, but the bigger evil is the giant parsing function that we need to break down first.
mavam
force-pushed
the
topic/environment-variables
branch
2 times, most recently
from
048fe80
to
4da964a
Compare
To the user, it doesn't matter whether locking takes place under the hood. They just want to get their environment worked. This is why the locked_ prefix no longer exists.
It turns out that other functions operate the same way, e.g., get_plugin_dirs takes also an actor_system_config. So we'll keep this as transport medium for now.
mavam
force-pushed
the
topic/environment-variables
branch
from
4da964a
to
3cd4bf5
Compare
lava
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
I investigated the last commit for a while, and it looks like the whole "convert settings based on the type in the configuration" is only done for options that come directly from caf. For the vast. options it looks like the default YAML/vast::data parser does (accidentally?) the correct thing already.
The logic on this part is pretty complicated so there may be some config parsing bugs left here, but even if so they would apply to the existing code and not be introduced by this PR so merging this should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new functionality to use environment variables as alternate input to a YAML config file.
馃摑 Checklist
VAST_andCAF_env vars into settings馃幆 Review Instructions
Commit-by-commit.