Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI verbosity shorthands #2178

Merged
merged 2 commits into from Apr 4, 2022
Merged

Fix CLI verbosity shorthands #2178

merged 2 commits into from Apr 4, 2022

Conversation

mavam
Copy link
Member

@mavam mavam commented Apr 3, 2022

This PR adds a patch to fix the mapping of shorthand verbosity options (e.g., -v, -q) to the proper underlying option --console-verbosity.

I realized that renaming --verbosity to --console-verbosity is actually a breaking change. We may want to revert it here, or in my opinion preferably, deprecate --verbosity in favor of --console-verbosity. The reason for preferring the latter is that it is the vocabulary used in the configuration files, as well as clearer what this does.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

Look at the one-line change. 馃憖

@mavam mavam added the bug Incorrect behavior label Apr 3, 2022
@dominiklohmann
Copy link
Member

I realized that renaming --verbosity to --console-verbosity is actually a breaking change.

This should get a separate changelog entry. I think the new name is better for the very reason you listed, but we should still document it.

@mavam mavam enabled auto-merge April 4, 2022 04:45
@mavam mavam merged commit 79eadf0 into master Apr 4, 2022
@mavam mavam deleted the topic/console-verbosity-fix branch April 4, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
2 participants