Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CEF reader plugin #2216

Merged
merged 28 commits into from Dec 13, 2022
Merged

Add CEF reader plugin #2216

merged 28 commits into from Dec 13, 2022

Conversation

mavam
Copy link
Member

@mavam mavam commented Apr 13, 2022 •
edited

This PR provides a reader plugin for the Common Event Format (CEF).

  • Parse structure
  • Perform structural type inference for extension schema
  • Perform inference on values
  • Add integration tests
  • Add documentation

@mavam mavam added the feature New functionality label Apr 13, 2022
@mavam mavam force-pushed the story/sc-32499/cef-parser branch from ca12aed to d3c5afb Compare April 13, 2022 15:32
@mavam mavam force-pushed the story/sc-32499/cef-parser branch 2 times, most recently from f15d7db to d6a0452 Compare December 10, 2022 21:58
mavam
mavam commented Dec 10, 2022
View reviewed changes
plugins/cef/src/parse.cpp Outdated Show resolved Hide resolved
@mavam mavam marked this pull request as ready for review December 11, 2022 14:43
tobim
tobim approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good for a v0.1. The inference might not always be right but that needs to be solved outside of this PR.

web/blog/vast-v2.5/index.md Outdated Show resolved Hide resolved
plugins/cef/src/parse.cpp Outdated Show resolved Hide resolved
plugins/cef/src/parse.cpp Outdated Show resolved Hide resolved
plugins/cef/src/parse.cpp Outdated Show resolved Hide resolved
plugins/cef/src/parse.cpp Outdated Show resolved Hide resolved
plugins/cef/include/cef/parse.hpp Outdated Show resolved Hide resolved
dominiklohmann
dominiklohmann approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor remarks; I'm glad you finally had the time to finish this.

plugins/cef/integration/data/cef/cef.log Outdated Show resolved Hide resolved
plugins/cef/src/add.cpp Show resolved Hide resolved
plugins/cef/src/plugin.cpp Outdated Show resolved Hide resolved
plugins/cef/src/plugin.cpp Outdated Show resolved Hide resolved
plugins/cef/include/cef/parse.hpp Outdated Show resolved Hide resolved
plugins/cef/include/cef/parse.hpp Outdated Show resolved Hide resolved
plugins/cef/include/cef/parse.hpp Outdated Show resolved Hide resolved
plugins/cef/src/add.cpp Outdated Show resolved Hide resolved
plugins/cef/src/plugin.cpp Outdated Show resolved Hide resolved
web/blog/vast-v2.5/index.md Outdated Show resolved Hide resolved
@mavam mavam enabled auto-merge December 13, 2022 09:20
@mavam mavam merged commit 7b15a14 into master Dec 13, 2022
@mavam mavam deleted the story/sc-32499/cef-parser branch December 13, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
3 participants
@mavam @tobim @dominiklohmann