Report by schema metrics from the importer #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
commented
May 10, 2022
tobim
commented
May 10, 2022
tobim
force-pushed
the
story/sc-28269/by-schema-import-metrics
branch
from
872cc54
to
5a5739f
Compare
tobim
force-pushed
the
story/sc-28269/by-schema-import-metrics
branch
from
e355d9c
to
5ee646a
Compare
aka parenthesized initialization of aggregates
Before this change metrics reports which bundle multiple metrics into a single message could only have a top level list of metadata attributes. This change makes it so each datapoint and performance sample can have metadata attached.
dominiklohmann
approved these changes
Jun 3, 2022
tobim
force-pushed
the
story/sc-28269/by-schema-import-metrics
branch
from
d28cd01
to
acb39cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the metrics that are reported from each individual source with an accumulated value from the importer. In other words, we now report how many events of a type were received at the node as opposed to how many were produced from a source.
馃摑 Checklist
馃幆 Review Instructions
Commit by commit.