Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the archive store-backend #2290

Merged
merged 3 commits into from May 20, 2022
Merged

Conversation

dominiklohmann
Copy link
Member

This removes the possibility for users to configure the archive for writing new data, and instead automatically sets the segment-store as the default store backend. Reading from the archive is still supported.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

The change is rather local in scope, so it should be covered by CI. I recommend reviewing file-by-file.

@dominiklohmann dominiklohmann added the maintenance Tasks for keeping up the infrastructure label May 20, 2022
@dominiklohmann dominiklohmann requested a review from a team May 20, 2022 07:20
This removes the possibility for users to configure the archive for writing new
data, and instead automatically sets the segment-store as the default store
backend. Reading from the archive is still supported.
vast/vast.cpp Outdated Show resolved Hide resolved
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I reviewed the diff and it looks sound. CI will catch the rest.

Co-authored-by: Matthias Vallentin <matthias@vallentin.net>
@dominiklohmann dominiklohmann merged commit 73516e0 into master May 20, 2022
@dominiklohmann dominiklohmann deleted the topic/deprecate-archive branch May 20, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
2 participants