-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve usability of CSV format #2336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I tested import (tsv, ssv) and export.
Thanks in particular for the extensive integration test coverage!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the following error when I use vast import --type=aws.flowlogs csv --separator=" "
:
vast.format.csv.reader encountered invalid vast.import.csv.separator ''; must be a single character
But the import seems to have worked fine...
Any Idea what might be happening?
That's an issue with how CAF parses the command line. If you use this instead it works:
|
@rdettai and I went over this in a call and discovered another issue with the CSV parser that is independent of the issues solved by this PR. I plan to take a further look tomorrow. |
yes, just to track the full context here: without the quotes arount
|
0b2fb5b
to
8cd7a2c
Compare
00d74f9
to
359c8d6
Compare
Three changes:
vast import csv --separator=...
option that defaults to,
, and tests it for space and tab separators.📝 Checklist
🎯 Review Instructions
@rdettai can you give this a try since you requested these?
For the actual code reviewer, take a look at it commit-by-commit.