Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The index shall not quit on write errors #2376

Merged
merged 2 commits into from Jun 24, 2022
Merged

The index shall not quit on write errors #2376

merged 2 commits into from Jun 24, 2022

Conversation

tobim
Copy link
Member

@tobim tobim commented Jun 23, 2022

The index used to quit if partitions fail to persist their data, this is not really necessary as VAST can still execute queries just fine when the disk is full.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

This should be trivial enough to accept without manual testing.

@tobim
The index shall not quit on write errors
650bf38 
The index used to quit if partitions fail to persist their data,
this is not really necessary as VAST can still execute queries just
fine when the disk is full.
@tobim
Add a changelog entry
4f7e70a
@tobim tobim added the bug Incorrect behavior label Jun 23, 2022
@tobim tobim requested a review from a team June 23, 2022 11:54
@tobim tobim marked this pull request as ready for review June 23, 2022 11:54
dispanser
dispanser approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@dispanser dispanser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's straight-forward.

I tested this by injecting a write error (via chown / chmod) and observed VAST keeping running.

@tobim tobim merged commit 3fe89aa into master Jun 24, 2022
@tobim tobim deleted the story/sc-34121/write-failure-is-not-a-hard-error branch June 24, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dispanser dispanser dispanser approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
2 participants
@tobim @dispanser