Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render reals with at least one decimal place #2393

Merged
merged 2 commits into from Jul 11, 2022
Merged

Render reals with at least one decimal place #2393

merged 2 commits into from Jul 11, 2022

Conversation

patszt
Copy link
Contributor

@patszt patszt commented Jul 1, 2022 •
edited

Json export will always render reals with at least one decimal place

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

@patszt patszt marked this pull request as draft July 1, 2022 14:12
@patszt patszt added the bug Incorrect behavior label Jul 1, 2022
@patszt patszt marked this pull request as ready for review July 4, 2022 10:02
lava
lava approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding new unit tests as well!

libvast/include/vast/concept/printable/vast/json.hpp Show resolved Hide resolved
@dominiklohmann
Copy link
Member

I think we should merge this one only after the v2.1 release. I'm adding a blocked label temporarily.

@dominiklohmann dominiklohmann added blocked Blocked by an (external) issue and removed blocked Blocked by an (external) issue labels Jul 4, 2022
@patszt patszt enabled auto-merge July 11, 2022 08:44
@patszt patszt merged commit 78f0707 into master Jul 11, 2022
@patszt patszt deleted the story/sc-34450 branch July 11, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
3 participants
@patszt @dominiklohmann @lava