Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run commands from scripts #2446

Merged
merged 13 commits into from Jul 27, 2022
Merged

Run commands from scripts #2446

merged 13 commits into from Jul 27, 2022

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Jul 20, 2022

Currently, you can run commands on the VAST lambda or server only from a string passed as option to a CLI commands. This makes it hard to provide more complex commands, among other because of escaping issues. It would be simpler if we could execute commands from a script store in a file.

馃摑 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on vast.io, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

馃幆 Review Instructions

  • docker is now binding the entire file system to make it possible to specify files that are outside the repository tree (@dispanser, this should also fix the git worktree issues) -> see cloud/vast/vast-cloud
  • --cmd option of run-lambda and execute-command now gets the
  • run-lambda and execute-command also take an --env list option to pass environment variables to the provided script.
  • also included an unrelated quick fix in cloud/aws/terraform/common/s3notif/inputs.tf because the dns resolution sometimes mysteriously fails with the default s3 domain

@rdettai rdettai added the feature New functionality label Jul 20, 2022
@rdettai rdettai requested a review from dispanser July 20, 2022 10:19
@rdettai rdettai self-assigned this Jul 20, 2022
@rdettai rdettai force-pushed the story/sc-35738/script-cmds branch from 8bb3dbe to bced6e4 Compare July 20, 2022 12:15
Copy link
Contributor

@dispanser dispanser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with run-lambda file:///...

@rdettai
Copy link
Contributor Author

rdettai commented Jul 20, 2022

I will add a few tests before merging

@rdettai
Copy link
Contributor Author

rdettai commented Jul 22, 2022

@rdettai
Copy link
Contributor Author

rdettai commented Jul 27, 2022

@rdettai rdettai enabled auto-merge July 27, 2022 12:11
@rdettai rdettai merged commit 7010f80 into master Jul 27, 2022
@rdettai rdettai deleted the story/sc-35738/script-cmds branch July 27, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
2 participants