New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run commands from scripts #2446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
force-pushed
the
story/sc-35738/script-cmds
branch
from
July 20, 2022 12:15
8bb3dbe
to
bced6e4
Compare
dispanser
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with run-lambda file:///...
I will add a few tests before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you can run commands on the VAST lambda or server only from a string passed as option to a CLI commands. This makes it hard to provide more complex commands, among other because of escaping issues. It would be simpler if we could execute commands from a script store in a file.
馃摑 Checklist
馃幆 Review Instructions
cloud/vast/vast-cloud
--cmd
option ofrun-lambda
andexecute-command
now gets therun-lambda
andexecute-command
also take an--env
list option to pass environment variables to the provided script.cloud/aws/terraform/common/s3notif/inputs.tf
because the dns resolution sometimes mysteriously fails with the default s3 domain