Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active partition actor to unpersisted partitions on decomission #2500

Merged
merged 2 commits into from Aug 16, 2022

Conversation

patszt
Copy link
Contributor

@patszt patszt commented Aug 16, 2022

馃摑 Reviewer Checklist

Active partition actor will be inserted into unpersisted partitions on decomission.
While running export and import concurrently we received many warning messages because we couldn't receive any partition_actor that was part of a query.

Review this pull request by ensuring the following items:

  • All user-facing changes have changelog entries
  • User-facing changes are reflected on vast.io

@patszt patszt added the bug Incorrect behavior label Aug 16, 2022
@patszt patszt marked this pull request as ready for review August 16, 2022 11:09
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already looked at this in a video call; the fix looks obviously correct so we will merge it and test in our testbed in the upcoming days.

@patszt patszt enabled auto-merge August 16, 2022 12:12
@patszt patszt merged commit 017de2f into master Aug 16, 2022
@patszt patszt deleted the story/sc-36201 branch August 16, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
2 participants