Cloud MISP

[rdettai]

This PR adds a MISP plugin to the cloud deployment

• after intensive experimentation with Ngrok and Cloudflare tunnel, these solutions where discarded:
  • too much per-requisits for the user (have an account, for cloudflare have a domain, for ngrok activate the paying tier)
  • hard to secure, especially TCP tunnels
• we went for a more traditional ssh tunnel with a keypair stored in the terraform state for now. This makes it harder to share the demo

📝 Reviewer Checklist

Review this pull request by ensuring the following items:

• All user-facing changes have changelog entries
• User-facing changes are reflected on vast.io

Also note that:

• You should rebuild the CLI (VASTCLOUD_REBUILD=1 ./vast-cloud)
• Changes to core were necessary to allow using EFS from the plugin
• We added sudo capabilities to the user in the CLI image to enable binding low ports
• In cloud/aws/resources/configs/misp/ configs where copied over from our internal repo. These should probably be shared with the docker-compose configs once they are ported to this repository

[rdettai]

[KaanSK]

After deployment, it is really unclear what is going on in the environment. Would it be possible to give a summary text on
ID/IP of MISP and Vast Server with available ports? It could be my lack of experience with these a bit but I needed to manually check stuff on both AWS and terraform code.

Additionally, what could be the reason for the output below? I expected the output to align with the test case. The screenshot is after the successful deployment. Instead of "No Task", a bit more verbose output could be shown.

[rdettai]

After deployment, it is really unclear what is going on in the environment. Would it be possible to give a summary text on
ID/IP of MISP and Vast Server with available ports? It could be my lack of experience with these a bit but I needed to manually check stuff on both AWS and terraform code.

Not sure how an ID/IP would be useful as the services are not exposed to the outside world. The ports are displayed when you start the tunneling, but maybe clearer listing would be nice.

Additionally, what could be the reason for the output below? I expected the output to align with the test case. The screenshot is after the successful deployment. Instead of "No Task", a bit more verbose output could be shown.

Did you start the service with misp.start as pointed out in the docs? I agree the message should be made more explicit.

[rdettai]

I made service status messages more explicit and fixed the integration test. Could you take a new look at it @KaanSK ?

[KaanSK]

I followed the instructions and I was able to get VAST Server, MISP instance up and ready. Approach seems more robust and status/error messages seems more verbose.

I went through the code both infra and logic related, to the extend of my knowledge. Put comment(s) on discussion points.

[dispanser]

Deployment works, and I'm able to both connect to MISP and log in.