Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable building unit tests in Dockerfile #2578

Merged
merged 1 commit into from Sep 14, 2022

Conversation

dominiklohmann
Copy link
Member

This was accidentally enabled in 7a6d9f3, so it was a newly introduced regression in v2.3 over v2.2 that massively increased the size of the Dockerfile.

馃摑 Reviewer Checklist

Review this pull request by ensuring the following items:

  • All user-facing changes have changelog entries
  • User-facing changes are reflected on vast.io

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Sep 14, 2022
This was accidentally enabled in 7a6d9f3, so it was a newly introduced
regression in v2.3 over v2.2 that massively increased the size of the
Dockerfile.
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from disabling unit tests, this also strips the executable and removes the build dir for space savings. Works.

@dominiklohmann dominiklohmann merged commit ea755e9 into master Sep 14, 2022
@dominiklohmann dominiklohmann deleted the topic/docker-no-unit-tests branch September 14, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
2 participants