Make feather the default store-backend
#2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
enhancement
performance
|
Meta review comment: you may want to fix the typo in your last commit. |
dominiklohmann
force-pushed
the
story/sc-36573/feather-by-default
branch
from
5c7a7e8
to
c9b2a66
Compare
All stores are partition partition-local nowadays, so this test hasn't made much sense in quite a while.
dominiklohmann
force-pushed
the
story/sc-36573/feather-by-default
branch
from
c9b2a66
to
6bc960e
Compare
dominiklohmann
force-pushed
the
story/sc-36573/feather-by-default
branch
from
84312cf
to
42a4b58
Compare
lava
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default
vast.store-backendtofeather.I filed this PR a bit earlier because I wanted to check whether there are any additional issues that CI finds that I don't see locally, so please don't review before this is out of draft mode.Reviewable now. I recommend going commit-by-commit.📝 Reviewer Checklist
Review this pull request by ensuring the following items: