New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CAF to version 0.18.6 #2693
Conversation
38be554
to
d67a75f
Compare
afe39f8
to
684377c
Compare
4c44b05
to
0788a10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review round: Everything that relates to the build scaffolding and CI. I really like what I'm seeing so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second part of the review: lsvast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part three: All the builtins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part four: plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part five: The test support library libvast_test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part six: FlatBuffers tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review round seven: About the first half of the libvast; I'm done for the day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Round eight: The remainder of libvast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly glanced at the tests as the changes were mostly mechanical. Initial testing shows that everything is working, even with an old database.
I would like to see this merged and then roll this out on our testbed for performance testing and to see what we need to tweak with the defaults.
There's one last warning I get when building, and this diff fixes it:
diff --git a/libvast/test/format/arrow.cpp b/libvast/test/format/arrow.cpp
index 54f3bacd9..a92fa5a0b 100644
--- a/libvast/test/format/arrow.cpp
+++ b/libvast/test/format/arrow.cpp
@@ -94,7 +94,8 @@ TEST(arrow IPC read) {
format::arrow::writer writer;
writer.out(stream);
for (auto& slice : zeek_conn_log)
- writer.write(slice);
+ if (auto err = writer.write(slice))
+ FAIL("failed to write zeek.conn log " << err);
auto data = stream->Finish().ValueOrDie()->ToString();
auto in = std::make_unique<std::istringstream>(std::string{data});
auto options = caf::settings{};
This PR is a fantastic piece of work 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a bunch of things—only action left to do (assuming that CI runs through) is to squash and then merge!
45d3ad8
to
22264ad
Compare
This PR bumps the CAF version to 0.18.6.
Some of the major weird things happening in the review: