Fix some shutdown issues in the web plugin #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are extracted from 'server_command.cpp', where they'll be removed in a subsequent commit.
lava
force-pushed
the
story/sc-38788/web-shutdown
branch
2 times, most recently
from
ec34a59
to
d0a13fa
Compare
tobim
reviewed
Jan 13, 2023
lava
force-pushed
the
story/sc-38788/web-shutdown
branch
from
41e4ea5
to
d0a13fa
Compare
This commit moves the web server into a separate thread so that the main thread can wait for DOWN messages and signal notifications in the meantime. It also fixes an issue where the spawned handlers would ignore an `exit_msg` with a default-constructed caf::error; we now send a user_shutdown message instead.
lava
force-pushed
the
story/sc-38788/web-shutdown
branch
from
d0a13fa
to
a92e829
Compare
lava
commented
Jan 16, 2023
Dakostu
approved these changes
Jan 18, 2023
|
@lava |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2/3 shutdown issues I found in the web plugin; in particular the web plugin now shuts down correctly when run as a separate command when receiving a signal and when detecting a node shutdown.
Note that it does not address the situation where
web serveris passed as a start command tovast start.