Trigger new compaction runs immediately on error #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/compaction-error-behavior
branch
from
cd59e56
to
b2d6c94
Compare
|
I changed the base to the related improvement branch so I can deploy it on the internal testbed. |
|
@dominiklohmann can I push here to fix the nix submodule rev? |
Yes, certainly. |
tobim
force-pushed
the
topic/compaction-error-behavior
branch
from
b2d6c94
to
f2fb3be
Compare
Failing in a compaction run should not cause VAST to wait for the configured interval until it starts a new run, as this may lead to the disk running full. This bumps the compaction plugin to include the changes done by @lava.
dominiklohmann
force-pushed
the
topic/compaction-error-behavior
branch
from
f2fb3be
to
e5727cc
Compare
lava
approved these changes
Mar 10, 2023
tobim
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing in a compaction run should not cause VAST to wait for the configured interval until it starts a new run, as this may lead to the disk running full. This bumps the compaction plugin to include the changes done by @lava to fix this behavior.