Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow /* ... */ comments in the VAST language #3011

Merged
merged 4 commits into from Mar 14, 2023

Conversation

dominiklohmann
Copy link
Member

This makes it possible to write comments in the VAST language directly using the /* comment */ that is familiar from many programming languages.

@dominiklohmann dominiklohmann added the feature New functionality label Mar 11, 2023
@dominiklohmann dominiklohmann requested a review from a team March 11, 2023 21:58
@dominiklohmann dominiklohmann force-pushed the topic/allow-comments-in-vast-exprs branch from b56d09a to 654d6a3 Compare March 11, 2023 21:59
@dominiklohmann dominiklohmann force-pushed the topic/allow-comments-in-vast-exprs branch from 654d6a3 to 6b41869 Compare March 12, 2023 10:01
Copy link
Member

@Dakostu Dakostu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with the comment functionality - this gets an approval from me. Left some minor things.

vast/integration/vast_integration_suite.yaml Outdated Show resolved Hide resolved
vast/integration/vast_integration_suite.yaml Show resolved Hide resolved
vast/integration/vast_integration_suite.yaml Show resolved Hide resolved
@dominiklohmann dominiklohmann merged commit 2128682 into master Mar 14, 2023
36 checks passed
@dominiklohmann dominiklohmann deleted the topic/allow-comments-in-vast-exprs branch March 14, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
2 participants