Reduce conflict potential between rebuilding and queries #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
requested review from
tobim and
patszt
and removed request for
tobim
patszt
approved these changes
Mar 31, 2023
dominiklohmann
commented
Mar 31, 2023
Rather than treating high as 4x medium and that as 25x low, we now always use a scaling factor of 1000x between query priorities, and consider partition transforms to have a priority of zero. In addition, we now prefer partitions with more related queries over those with fewer related queries given an otherwise equal priority. This reduces the conflict potentual between rebuilds, compaction, and queries. Additionally, this commit adds logs for the number of scheduled partitions by the index, which helped debug this issue and is generally worth having.
dominiklohmann
force-pushed
the
topic/partition-transform-priority
branch
from
0b95819
to
4dfdaae
Compare
tobim
requested changes
Mar 31, 2023
There was a problem hiding this comment.
It's good that we fix this issue, albeit with a band-aid. However I would like to avoid allowing an even bigger value space for priorities at the same time.
When we refactor the catalog we should eventually change this so rebuilds don't appear as queries any more to avoid similar problems in the future.
tobim
approved these changes
Mar 31, 2023
dominiklohmann
added a commit
that referenced
this pull request
Mar 31, 2023
This PR backports #3047 and prepares the repository for a new patch release on the v2.4.x branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a large value in
vast.rebuild.parallelorvast.automatic-rebuildand a low value invast.max-queries, VAST may end up in a state in which the state at which it is able to respond to queries is limited by the speed at which it is able to rebuild.This fixes that issue, and then adds some additional logging that helped find this bug.