Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tail operator #3050

Merged
merged 2 commits into from Apr 2, 2023
Merged

Add tail operator #3050

merged 2 commits into from Apr 2, 2023

Conversation

Dakostu
Copy link
Member

@Dakostu Dakostu commented Mar 31, 2023

This PR adds the tail operator. Currently only available as a new crtp_operator.

@Dakostu Dakostu added the feature New functionality label Mar 31, 2023
@Dakostu Dakostu requested a review from a team March 31, 2023 10:46
@Dakostu Dakostu force-pushed the topic/implement-tail-operator branch 2 times, most recently from d5958eb to e53870c Compare March 31, 2023 11:21
@Dakostu Dakostu force-pushed the topic/implement-tail-operator branch 4 times, most recently from 200ffeb to 0478d25 Compare March 31, 2023 13:19
dominiklohmann
dominiklohmann approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great; tests are rather minimal, which we should improve once we have this available via vast exec. Just two minor things remaining.

libvast/builtins/operators/tail.cpp Outdated Show resolved Hide resolved
web/docs/understand/language/operators/tail.md Show resolved Hide resolved
@Dakostu Dakostu force-pushed the topic/implement-tail-operator branch from 0478d25 to 5240295 Compare March 31, 2023 13:35
@Dakostu Dakostu marked this pull request as ready for review March 31, 2023 13:36
@Dakostu Dakostu enabled auto-merge March 31, 2023 13:51
@Dakostu Dakostu force-pushed the topic/implement-tail-operator branch from 5240295 to b0d61dc Compare March 31, 2023 14:43
@dominiklohmann dominiklohmann changed the title Add "tail" operator Add tail operator Apr 2, 2023
@Dakostu Dakostu merged commit e2f79cf into main Apr 2, 2023
39 of 40 checks passed
@Dakostu Dakostu deleted the topic/implement-tail-operator branch April 2, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jachris jachris jachris left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
3 participants
@Dakostu @dominiklohmann @jachris