-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement file
loader
#3088
Implement file
loader
#3088
Conversation
f117e0d
to
001e666
Compare
You might want to consider overriding For the loader, this effect is rather subtle, but for the saver you most definitely want to override it. Edit: There is another alternative, which is to put the side-effects into the returned generator, such that they will not be executed as part of type checking. |
1c8a2e5
to
1edb768
Compare
f83454f
to
c463109
Compare
358e35e
to
ade716d
Compare
ade716d
to
ef0f9f5
Compare
0ef9d57
to
f4b16d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we are now very close to having a file loader 🎉
Sorry for writing so many comments – most of them are nits or questions. I would like to take one final look after things are clarified.
61e09d4
to
a3b046c
Compare
4158b5d
to
3ad3012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I think this will be complete after the open points have been addressed 🎉
c46fce7
to
e0bd40f
Compare
8e17121
to
e70320a
Compare
e70320a
to
d5cbd2e
Compare
This PR implements a
file
loader with an optional--timeout
parameter that forwards regular and UDS file input to the next pipeline operator.This loader also replaces the
stdin
loader.