Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement xsv parser & printer #3104

Merged
merged 11 commits into from Apr 27, 2023
Merged

Implement xsv parser & printer #3104

merged 11 commits into from Apr 27, 2023

Conversation

Dakostu
Copy link
Member

@Dakostu Dakostu commented Apr 26, 2023

This PR adds an xsv parser and printer that enables the user to parse and print character-separated values, with specializations for csv, tsv and ssv.

@Dakostu Dakostu requested a review from jachris April 26, 2023 14:45
@Dakostu Dakostu added the feature New functionality label Apr 26, 2023
dominiklohmann
dominiklohmann approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed this in the office together. Some open TODOs still, but ready to be merged regardless as we have follow-up issues for all outstanding items.

@Dakostu Dakostu enabled auto-merge April 27, 2023 12:58
@Dakostu Dakostu merged commit 06fa8b5 into main Apr 27, 2023
19 checks passed
@Dakostu Dakostu deleted the topic/csv-writer branch April 27, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

@jachris jachris Awaiting requested review from jachris

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
3 participants
@Dakostu @dominiklohmann @jachris